Differential D11491

Don't calculate attribute() twice.
ClosedPublic
Actions

Authored by jtamate on Mar 19 2018, 4:29 PM.

Details

Reviewers
dhaumann
Group Reviewers
Frameworks
Kate
Commits
R39:91999f6e9116: Don't calculate attribute() twice.
Summary

"kateTextLine" neither "i" shouldn't have changed since the first call to attribute two lines ago.

Test Plan

Open a XML file with 4 lines and a line of 566039 characters long.

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jtamate created this revision.Mar 19 2018, 4:29 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMar 19 2018, 4:29 PM
jtamate requested review of this revision.Mar 19 2018, 4:29 PM
dhaumann accepted this revision.Mar 20 2018, 8:18 AM
dhaumann added a subscriber: dhaumann.

Looks good to me.

This revision is now accepted and ready to land.Mar 20 2018, 8:18 AM
Closed by commit R39:91999f6e9116: Don't calculate attribute() twice. (authored by jtamate). · Explain WhyMar 21 2018, 6:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/spellcheck/spellcheck.cpp (3 lines)

Diff 30137

View Options

src/spellcheck/spellcheck.cpp

Loading...