| elvisangelaccio |
Move mimetype-handling functions to own file (mimetypes.cpp). In MainWindow::openArchive() set filter using QFileDialog::setMimeTypeFilters() instead of using QFileDialog::setNameFilters().
This fixes sorting of filters in "Open Archive" dialog with KF 5.20.0. Frameworkintegration 5.20.0 broke this sorting due to commit 415ad2ed48356c3065c937813888fa1bd2742789.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
I don't get the "All supported archives" filter. Is that normal?
Another thing, I would also move the determineMimeType() function from archive_kerfuffle.cpp to this new source file :)
| app/extractHereDndPlugin.cpp | ||
|---|---|---|
| 30 | Unnecessary include | |
| kerfuffle/mimetypes.cpp | ||
| 29 | Move also the static findExecutables() function in this new file, so that you don't need to include this header here. | |
| 55 | This will add duplicate mimetypes in the list (even though they are discarded later thanks to the QMap). Better to leave the local supported variable as QSet, then you can just return sortByComment(supported) at the end of the function. | |
| 70 | const QSet &... | |
| 83 | foreach (key, map.keyList()) ? less verbose :) | |
| kerfuffle/mimetypes.h | ||
| 36 | Please add a doxygen comment, explaining that this function returns a list sorted by comment. | |
"All supported archives/types" filter is important in an Open dialog to be able to see all file types that the program supports. Previously, we had to construct it ourselves, but now QFileDialog::setMimeFilters() does it for us automatically.
I don't have it in the open dialog (7z is the first filter). Maybe because I'm still with frameworkintegration 5.19?
| kerfuffle/mimetypes.h | ||
|---|---|---|
| 37 | Would you mind adding the doxygen comments after I've pushed this diff? I have no idea how the syntax is... | |
| kerfuffle/mimetypes.h | ||
|---|---|---|
| 37 | Ok, no problem :) | |
| kerfuffle/mimetypes.h | ||
|---|---|---|
| 37 | Even better, I'll write it here. Just add the following comment: /** * @return A list with the supported read-only mimetypes, alphabetically sorted according to their comment. */ | |