Differential D11437

Always show/hide both next and previous buttons
ClosedPublic
Actions

Authored by mtijink on Mar 17 2018, 9:26 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:9840a39992ed: Always show/hide both next and previous buttons
Summary

As @kossebau mentioned, a disappearing "previous" button is not really great, since you'll likely press "next". This diff makes sure that when you can press previous and/or next, both buttons are shown (potentially disabled).

Test Plan

Works in all combinations of enabled/disabled for both buttons

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mtijink requested review of this revision.Mar 17 2018, 9:26 PM
mtijink created this revision.
albertvaka accepted this revision.Mar 23 2018, 6:03 PM
This revision is now accepted and ready to land.Mar 23 2018, 6:03 PM
Closed by commit R225:9840a39992ed: Always show/hide both next and previous buttons (authored by mtijink). · Explain WhyMar 23 2018, 6:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30339

View Options

src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java

Loading...