Differential D1141

Hide status bar on idle
ClosedPublic
Actions

Authored by elvisangelaccio on Mar 13 2016, 11:08 PM.

Details

Reviewers
rthomsen
Commits
R36:0f539042fafd: Hide status bar on idle
Summary

The Ark status bar is useful only during jobs, when showing the job's
progress bar. With this patch we show the status bar only during a job, saving screen
space otherwise.

This patch also removes the "Show the status-bar" checkbox from the Settings
menu, since does not make sense anymore to have it.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 2762.Mar 13 2016, 11:08 PM
elvisangelaccio retitled this revision from to Hide status bar on idle.
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio updated this object.
Restricted Application added a project: Ark. · View Herald TranscriptMar 13 2016, 11:08 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
rthomsen accepted this revision.Mar 14 2016, 2:18 PM
rthomsen edited edge metadata.

Code looks good and works for me. Death to status bar!

This revision is now accepted and ready to land.Mar 14 2016, 2:18 PM
tillschafer added a subscriber: tillschafer.Mar 14 2016, 2:37 PM

isn't this proposal here quite similar to this one: https://phabricator.kde.org/T1769 ?

elvisangelaccio added a comment.Mar 14 2016, 2:53 PM
In D1141#21687, @tillschafer wrote:

isn't this proposal here quite similar to this one: https://phabricator.kde.org/T1769 ?

This is the implementation of that proposal :)

Closed by commit R36:0f539042fafd: Hide status bar on idle (authored by elvisangelaccio). · Explain WhyMar 14 2016, 3:38 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:0f539042fafd: Hide status bar on idle.
tillschafer added a comment.Mar 14 2016, 4:13 PM
In D1141#21689, @elvisangelaccio wrote:
In D1141#21687, @tillschafer wrote:

isn't this proposal here quite similar to this one: https://phabricator.kde.org/T1769 ?

This is the implementation of that proposal :)

Aww :-)
A slightly off-topic question (sorry for polluting this task): Does there exist any linkage between proposals and implementations in phabricator?

elvisangelaccio added a comment.Mar 14 2016, 4:15 PM
In D1141#21697, @tillschafer wrote:
In D1141#21689, @elvisangelaccio wrote:
In D1141#21687, @tillschafer wrote:

isn't this proposal here quite similar to this one: https://phabricator.kde.org/T1769 ?

This is the implementation of that proposal :)

Aww :-)
A slightly off-topic question (sorry for polluting this task): Does there exist any linkage between proposals and implementations in phabricator?

Yes. I should have attached the task to this review, actually :p

Revision Contents
Changeset List

PathPackages
Mapp/mainwindow.cpp (4 lines)
Mpart/part.cpp (3 lines)

Diff 2772

View Options

app/mainwindow.cpp

Loading...
View Options

part/part.cpp

Loading...