When seeking isn't possible but the track duration is known, show a progress bar instead of showing nothing.
A progress bar is also much nicer than a disabled slider here as it's then meant as an indicator instead.
Details
Details
Disabled slider:
Progress bar (this patch)
- Verified that it is not shown when streaming music where length isn't known
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
+1, looks great to me.
Bit of duplicate control, but given there can be one at most, that seems fine to me.
Also progress bar makes sense, since a playing track is progress, so it should even look good if other plasma themes decide to use something completely different looking for that compared to the slider.
Comment Actions
Thanks for the quick patch, works nicely with my CanSeek=false gwenview position WIP patch :)