Differential D1129

Add a default mode event to ServerSideDecorationManager
ClosedPublic
Actions

Authored by graesslin on Mar 12 2016, 10:56 AM.

Details

Reviewers

sebas

Group Reviewers

Plasma

Commits

R127:ba479e3ee250: Add a default mode event to ServerSideDecorationManager

Summary

The ServerSideDecorationManager gains a new event which gets sent
to the client when it binds the manager. The event indicates the
default server decoration mode used by the server. This allows the
client to know the decoration mode when it creates a decoration and
thus does not need to roundtrip to the server to get the mode.

Diff Detail

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 2732.Mar 12 2016, 10:56 AM

graesslin retitled this revision from to Add a default mode event to ServerSideDecorationManager.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: Plasma, sebas.

Restricted Application added a project: Plasma. · View Herald TranscriptMar 12 2016, 10:56 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

graesslin added a dependent revision: D1130: Set the decoration mode if it doesn't match the server's default mode.Mar 12 2016, 11:00 AM

sebas accepted this revision.Mar 12 2016, 11:21 AM

sebas edited edge metadata.

sebas added inline comments.

src/client/protocols/server-decoration.xml
53	till -> until
54	requestMode() makes more sense here

This revision is now accepted and ready to land.Mar 12 2016, 11:21 AM

graesslin marked 2 inline comments as done.Mar 12 2016, 11:29 AM

graesslin added inline comments.

src/client/protocols/server-decoration.xml
54	This is a protocol and not a C-based programming language ;-) I changed it to "request_mode is requested"

Closed by commit R127:ba479e3ee250: Add a default mode event to ServerSideDecorationManager (authored by graesslin). · Explain WhyMar 12 2016, 11:49 AM

This revision was automatically updated to reflect the committed changes.

graesslin marked an inline comment as done.

Revision Contents
Changeset List

			Path	Packages
M			src/client/protocols/server-decoration.xml (17 lines)
M			src/client/server_decoration.h (7 lines)
M			src/client/server_decoration.cpp (100 lines)
M			src/server/server_decoration_interface.cpp (50 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2732	8df30e1		Mar 12 2016, 10:56 AM	★	★
Diff 2	2735	8df30e1	rKWAYLANDba479e3ee250eda29aad39bad38c22edba552f53	Mar 12 2016, 11:29 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
e0c161dce2e0	8b704de2b438	8df30e1bcecc	Martin Gräßlin	Add a default mode event to ServerSideDecorationManager (Show More…)	Mar 12 2016, 10:53 AM

	Status	Author	Revision
	Closed	graesslin	D1130 Set the decoration mode if it doesn't match the server's default mode
	Closed	graesslin	D1129 Add a default mode event to ServerSideDecorationManager