Differential D11280

Set default path of "Copy/Move/Link To" dialog to current folder
ClosedPublic
Actions

Authored by muhlenpfordt on Mar 13 2018, 10:25 AM.

Details

Reviewers
rkflx
Group Reviewers
Gwenview
Commits
R260:fee2942254d6: Set default path of "Copy/Move/Link To" dialog to current folder
Summary

D8785 introduced QStandardPaths::PicturesLocation as default
location for Copy/Move/Link To dialog.
This patch sets the starting folder to the current folder (where
the source image(s) resist). It also provides an easier handling
of switching off the history option in D11263.

CCBUG: 391527

Test Plan
  • Clear LastTargetDir config entry (e.g. remove ~/.config/gwenviewrc)
  • Start Gwenview
  • Select one or more images and press F7 to copy
  • Dialog should start in current folder

Diff Detail

Repository
R260 Gwenview
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
muhlenpfordt requested review of this revision.Mar 13 2018, 10:25 AM
muhlenpfordt created this revision.
muhlenpfordt added a reviewer: Gwenview.Mar 13 2018, 10:32 AM
muhlenpfordt added inline comments.
app/fileoperations.cpp
99–105

Operating with multiple files leads to wrong starting folder if QUrl() is used with setDirectoryUrl().

rkflx accepted this revision.Mar 13 2018, 8:29 PM
This revision is now accepted and ready to land.Mar 13 2018, 8:29 PM
Closed by commit R260:fee2942254d6: Set default path of "Copy/Move/Link To" dialog to current folder (authored by muhlenpfordt). · Explain WhyMar 14 2018, 8:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapp/fileoperations.cpp (7 lines)
Mlib/contextmanager.cpp (2 lines)
Mlib/gwenviewconfig.kcfg (3 lines)

Diff 29463

View Options

app/fileoperations.cpp

Loading...
View Options

lib/contextmanager.cpp

Loading...
View Options

lib/gwenviewconfig.kcfg

Loading...