Trigger a roundtrip after creating the ServerSideDecoration
AbandonedPublic

Authored by graesslin on Mar 12 2016, 8:23 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Summary

The server sends out the desired mode directly after creating the
ServerSideDecoration. By triggering a roundtrip we make sure that
we now how the server wants us to render the window before we start
to render the window.

Also it prevents the server to create and directly destroy a server
decoration if it defaults to server decoration and the window is going
to be client side decorated.

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Branch
kwayland-roundtrip-server
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin updated this revision to Diff 2727.Mar 12 2016, 8:23 AM
graesslin retitled this revision from to Trigger a roundtrip after creating the ServerSideDecoration.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptMar 12 2016, 8:23 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Mar 12 2016, 9:22 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Mar 12 2016, 9:22 AM
graesslin added inline comments.Mar 12 2016, 9:32 AM
src/platformtheme/kwaylandintegration.cpp
93

I'm not really happy with the solution. It works, but it introduces a roundtrip. Maybe it's better to adjust the protocol to send out the default on binding the interface.