Differential D1127

ItemRepository: Fix memory leak
ClosedPublic
Actions

Authored by kfunk on Mar 12 2016, 12:30 AM.

Details

Reviewers
mwolff
Commits
R33:d35c56df6b1d: ItemRepository: Fix memory leak
R32:d35c56df6b1d: ItemRepository: Fix memory leak
Summary

Remove hack for intentional leak of item repository buckets. KDevelop seems
to function fine without the hack.

Removes a lot of junk from the ASAN leak report

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk updated this revision to Diff 2726.Mar 12 2016, 12:30 AM
kfunk retitled this revision from to ItemRepository: Fix memory leak.
kfunk updated this object.
kfunk edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMar 12 2016, 12:30 AM
kfunk added a comment.Mar 12 2016, 12:31 AM

No crashes when loading bigger kdev-php and kdev-python projects, too.

mwolff accepted this revision.Mar 12 2016, 7:49 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

considering you run with asan and this doesn't trigger fails for you, big +1 from my side!

nice job :) thanks for taking care of this

This revision is now accepted and ready to land.Mar 12 2016, 7:49 PM
Closed by commit R33:d35c56df6b1d: ItemRepository: Fix memory leak (authored by kfunk). · Explain WhyMar 14 2016, 10:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mserialization/itemrepository.h (5 lines)

Diff 2768

View Options

serialization/itemrepository.h

Loading...