Differential D11225

Remove scrolling on sliders in config menu
ClosedPublic
Actions

Authored by abreton on Mar 11 2018, 9:26 AM.

Details

Reviewers
timotheegiet
Group Reviewers
GCompris: Improvements
Summary

I felt a little bothered when scrolling using a touchpad in the configuration menu from the main menu because it was modifying the sliders "font size" and "font letter spacing" unintentionally.

As the Slider's property "wheelEnabled" is only available for Qt.Quick.Controls 1.6 or 2, I did differently.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
abreton created this revision.Mar 11 2018, 9:26 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 11 2018, 9:26 AM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
abreton requested review of this revision.Mar 11 2018, 9:26 AM
timotheegiet accepted this revision.Mar 11 2018, 6:56 PM
timotheegiet added a subscriber: timotheegiet.

Thanks, pushed.

This revision is now accepted and ready to land.Mar 11 2018, 6:56 PM
timotheegiet closed this revision.Mar 11 2018, 6:57 PM
jjazeix added a subscriber: jjazeix.Mar 11 2018, 8:35 PM
jjazeix added inline comments.
src/activities/menu/ConfigurationItem.qml
1

not needed

290

not needed (it's already true by default)

293

could be factorised on a separate item (https://phabricator.kde.org/T8182)

Revision Contents
Changeset List

Diff 29212

View Options

src/activities/menu/ConfigurationItem.qml

Loading...