Details
- Reviewers
sitter mak - Commits
- R550:968a0d70bd92: Add AppStream metadata
Diff Detail
- Repository
- R550 Muon
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/org.kde.muon.appdata.xml | ||
---|---|---|
14 | huh? That should be System, no? |
src/org.kde.muon.appdata.xml | ||
---|---|---|
14 | I also thought so, and that's what is in the desktop file. But https://specifications.freedesktop.org/menu-spec/latest/apas02.html indicates "Settings" as the related category for "PackageManager". |
src/org.kde.muon.appdata.xml | ||
---|---|---|
14 | Oh my, yeah, that's a fairly stupid hint. Settings is a fairly unfortunate category because it can have a multitude of UIs which may or may not make sense for the app. Quick inventory:
So I'd go with System TBH. Mind you, I think you can drop categories entirely, appstream-generator (the distro tooling bit of appstream) will automatically fill additional info (such as categories) from the desktop file AFAIK. |
src/org.kde.muon.appdata.xml | ||
---|---|---|
3 | Nitpick: You can put "desktop-application" here, it's more modern. Won't make any functional difference though, "desktop" is an alias to that. | |
4 | Please drop the .desktop suffix from the ID, it's not needed. | |
5 | Using "FSFAP" as license is likely nicer to distros summarizing copyrights for every file. CC0 is quite a verbose license, FSFAP is one line. | |
14 |
It does :-) The data in the metainfo file always beats what's in the .desktop file though (overriding it). | |
29 | For a new metainfo file, providing an old ID doesn't make much sense (but also doesn't hurt). | |
31 | This metainfo file requires a launchable tag (type: desktop-id). |
Since categories is now the same as in the desktop file you can simply drop it. appstream-generator will merge the desktop file's data in. Otherwise looks good now
I also modified the template in the wiki page with the suggested changes. I hope that's fine.
https://community.kde.org/Guidelines_and_HOWTOs/AppStream
src/org.kde.muon.appdata.xml | ||
---|---|---|
29 | Is is there because the desktop file has been renamed (in another patch). |
That's not just fine, it's even better :-) Thanks!
(I just changed the "optional" statement from the launchable tag to "recommended", because if that tag is missing, the application can not be launched from the software center)
Looks good to me now :-)