Add AppStream metadata
ClosedPublic

Authored by vanini on Mar 5 2018, 12:04 PM.

Diff Detail

Repository
R550 Muon
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vanini requested review of this revision.Mar 5 2018, 12:04 PM
vanini created this revision.
sitter requested changes to this revision.Mar 5 2018, 12:21 PM
sitter added inline comments.
src/org.kde.muon.appdata.xml
14

huh?

That should be System, no?

This revision now requires changes to proceed.Mar 5 2018, 12:21 PM
vanini added inline comments.Mar 5 2018, 1:32 PM
src/org.kde.muon.appdata.xml
14

I also thought so, and that's what is in the desktop file. But https://specifications.freedesktop.org/menu-spec/latest/apas02.html indicates "Settings" as the related category for "PackageManager".

sitter added inline comments.Mar 5 2018, 2:27 PM
src/org.kde.muon.appdata.xml
14

Oh my, yeah, that's a fairly stupid hint.

Settings is a fairly unfortunate category because it can have a multitude of UIs which may or may not make sense for the app.

Quick inventory:

  • muon, discover, gnome-software use System
  • apper, synaptic use System AND Settings

So I'd go with System TBH.

Mind you, I think you can drop categories entirely, appstream-generator (the distro tooling bit of appstream) will automatically fill additional info (such as categories) from the desktop file AFAIK.

mak requested changes to this revision.Mar 5 2018, 3:02 PM
mak added inline comments.
src/org.kde.muon.appdata.xml
3

Nitpick: You can put "desktop-application" here, it's more modern. Won't make any functional difference though, "desktop" is an alias to that.

4

Please drop the .desktop suffix from the ID, it's not needed.

5

Using "FSFAP" as license is likely nicer to distros summarizing copyrights for every file. CC0 is quite a verbose license, FSFAP is one line.
https://spdx.org/licenses/FSFAP.html

14

Mind you, I think you can drop categories entirely, appstream-generator (the distro tooling bit of appstream) will automatically fill additional info (such as categories) from the desktop file AFAIK.

It does :-) The data in the metainfo file always beats what's in the .desktop file though (overriding it).

29

For a new metainfo file, providing an old ID doesn't make much sense (but also doesn't hurt).

31

This metainfo file requires a launchable tag (type: desktop-id).
See https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable

vanini updated this revision to Diff 28830.Mar 6 2018, 1:59 PM

apply suggested changes

sitter requested changes to this revision.Mar 6 2018, 2:02 PM

Since categories is now the same as in the desktop file you can simply drop it. appstream-generator will merge the desktop file's data in. Otherwise looks good now

This revision now requires changes to proceed.Mar 6 2018, 2:02 PM
vanini marked 7 inline comments as done.Mar 6 2018, 2:05 PM

I also modified the template in the wiki page with the suggested changes. I hope that's fine.
https://community.kde.org/Guidelines_and_HOWTOs/AppStream

src/org.kde.muon.appdata.xml
29

Is is there because the desktop file has been renamed (in another patch).

vanini updated this revision to Diff 28831.Mar 6 2018, 2:06 PM

drop categories

sitter accepted this revision.Mar 6 2018, 2:12 PM

Thanks for updating the wiki 👍

mak accepted this revision.Mar 6 2018, 2:18 PM

I also modified the template in the wiki page with the suggested changes. I hope that's fine.
https://community.kde.org/Guidelines_and_HOWTOs/AppStream

That's not just fine, it's even better :-) Thanks!
(I just changed the "optional" statement from the launchable tag to "recommended", because if that tag is missing, the application can not be launched from the software center)

Looks good to me now :-)

This revision is now accepted and ready to land.Mar 6 2018, 2:18 PM
This revision was automatically updated to reflect the committed changes.