Starting 5.31 KNotificationRestriction supports reason text which is shown in battery and brightness applet.
Bump minimum required version of KF5 and Qt
Details
Details
- Reviewers
sitter - Commits
- R259:c0d82f24729d: Show inhibition text
before:
after:
Diff Detail
Diff Detail
- Repository
- R259 Dragon Player
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Are you sure this is used in the battery applet? I really don't see how notifications relate to that applet. Surely it'd be using PM inhibitions which are an entirely different thing?
| CMakeLists.txt | ||
|---|---|---|
| 68 | You could just remove the flag entirely, it's only used in main.cpp to conditionally use kcrash api. | |
| src/app/mainWindow.cpp | ||
| 839 | Please use i18nc to give translators a context for this string. Something like "Notification inhibition reason". https://techbase.kde.org/Development/Tutorials/Localization/i18n#Adding_Context_with_i18nc.28.29 Also, this should probably start with a capital P. | |
Comment Actions
Why does the battery applet show the inhibition for *notifications*?
That class is poorly named and the code clearly creates a screensaver inhibition which are shown in battery monitor as intended. (This is also consistent with Chromium which also shows "Playing video" etc)
Comment Actions
Fair enough but even screensaver inhibition isn't the same as power management inhibition?
Comment Actions
Fair enough but even screensaver inhibition isn't the same as power management inhibition?
It's something that keeps your screen on and is all that counts for that.