Differential D11037

balooctl: checkDb should also verify the last known url for the documentId.
ClosedPublic
Actions

Authored by smithjd on Mar 5 2018, 12:19 AM.

Details

Reviewers
michaelh
Group Reviewers
Baloo
Commits
R293:3fbabac6add9: balooctl: checkDb should also verify the last known url for the documentId.
Summary

Report orphan documentId's.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
smithjd created this revision.Mar 5 2018, 12:19 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 5 2018, 12:19 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
smithjd requested review of this revision.Mar 5 2018, 12:19 AM
michaelh added a subscriber: michaelh.Mar 5 2018, 9:51 AM

balooctl checkDb is no more. See D10778. We could turn it into a separate executable like 'balooDbDebug' or so. It should be made clear then that it is for developers only.

smithjd added a comment.Mar 5 2018, 7:40 PM

This change includes orphan file entries as invalid database entries in checkFsTree().

michaelh accepted this revision as: michaelh.Mar 7 2018, 9:33 AM
In D11037#219358, @smithjd wrote:

This change includes orphan file entries as invalid database entries in checkFsTree().

Currently it is unreachable, because the 'checkDb' options has been removed in D10778. Please consider to create an executable for checkdb in tests/ folder.

This revision is now accepted and ready to land.Mar 7 2018, 9:33 AM
Closed by commit R293:3fbabac6add9: balooctl: checkDb should also verify the last known url for the documentId. (authored by smithjd). · Explain WhyMar 8 2018, 3:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/engine/transaction.cpp (3 lines)

Diff 29016

View Options

src/engine/transaction.cpp

Loading...