balancebox: Hiding bar buttons by default
Needs RevisionPublic

Authored by rajatasthana on Mar 4 2018, 8:29 PM.

Details

Summary

Hiding the bar buttons by default at the start of Balance box activity.

Diff Detail

Repository
R2 GCompris
Branch
balancebox
Lint
No Linters Available
Unit
No Unit Test Coverage
rajatasthana created this revision.Mar 4 2018, 8:29 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 4 2018, 8:29 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
rajatasthana requested review of this revision.Mar 4 2018, 8:29 PM
rajatasthana retitled this revision from Hiding bar buttons by default at the start of activity to Hiding bar buttons by default .Mar 4 2018, 8:39 PM
rajatasthana edited the summary of this revision. (Show Details)
rajatasthana added a project: GCompris.
rajatasthana added a subscriber: GCompris.
jjazeix retitled this revision from Hiding bar buttons by default to balancebox: Hiding bar buttons by default .Mar 4 2018, 8:40 PM
jjazeix edited projects, added GCompris: Improvements; removed GCompris.

It would be better to resize the content to not have to hide the bar.
Hiding the bar by default can perturb the user and should not be done when possible.

rajatasthana retitled this revision from balancebox: Hiding bar buttons by default to balancebox: Hiding bar buttons by default.
  • changed the margin so that ball is no longer hidden behind the bar
  • setting the pixel value so that it works with all resolutions
timotheegiet added a comment.EditedMar 5 2018, 12:38 PM

This is really not the right solution. We need to increase the margin at the bottom to at least the height of the bar, but keep it close to the top of the screen.
(I won't tell you exactly what to change, that's 90% of the work to think about this ;) )

jjazeix requested changes to this revision.Mar 10 2018, 1:58 PM
This revision now requires changes to proceed.Mar 10 2018, 1:58 PM