Differential D1102

Add brackets for operator precedence
ClosedPublic
Actions

Authored by flherne on Mar 10 2016, 11:04 AM.

Details

Reviewers
mwolff
Commits
R52:30a0cc9aace5: Add brackets for operator precedence
Summary

GCC warns about this with -Wparentheses, applying operators in the right order seems like a good idea.

Test Plan

Recompiled, no compiler warning.

Diff Detail

Repository
R52 KDevelop: PHP Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
flherne updated this revision to Diff 2657.Mar 10 2016, 11:04 AM
flherne retitled this revision from to Add brackets for operator precedence.
flherne updated this object.
flherne edited the test plan for this revision. (Show Details)
flherne set the repository for this revision to R52 KDevelop: PHP Support.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMar 10 2016, 11:04 AM
flherne added a comment.Mar 10 2016, 11:05 AM

Very trivial change for my first KDE patch. Not sure if I've done the Phabricator stuff right...

mwolff accepted this revision.Mar 11 2016, 12:16 PM
mwolff added a project: KDevelop.
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

ouch!

This revision is now accepted and ready to land.Mar 11 2016, 12:17 PM
Closed by commit R52:30a0cc9aace5: Add brackets for operator precedence (authored by kfunk). · Explain WhyMar 12 2016, 6:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2749

View Options

completion/item.cpp

Loading...
View Options

duchain/builders/declarationbuilder.cpp

Loading...