Simplify mimetypes handling
ClosedPublic

Authored by elvisangelaccio on Mar 9 2016, 5:44 PM.

Details

Summary

Now that we have the Archive::mimeType() function, we can use it to return
directly a QMimeType object, which simplifies a lot many places in the code.

I also added the mimetype comment in the properties dialog, which is more user-frienfly.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio retitled this revision from to Simplify mimetypes handling.
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio updated this object.
Restricted Application added a project: Ark. · View Herald TranscriptMar 9 2016, 5:44 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript

Screenshot of the new properties dialog:

rthomsen accepted this revision.Mar 9 2016, 6:11 PM
rthomsen edited edge metadata.

Looks good ;)

app/batchextract.cpp
70

QLatin1String would be faster than QStringLiteral here.

This revision is now accepted and ready to land.Mar 9 2016, 6:11 PM
elvisangelaccio edited edge metadata.
  • Use QLatin1String for comparison
elvisangelaccio marked an inline comment as done.Mar 9 2016, 6:14 PM
This revision was automatically updated to reflect the committed changes.