Differential D10957

Attempt to build atcore flatpak
ClosedPublic
Actions

Authored by rizzitello on Mar 1 2018, 11:43 PM.

Details

Reviewers
apol
Group Reviewers
Flatpak
Commits
R256:2820ca2b2eb9: Attempt to build atcore flatpak
Summary

Create org.kde.atcore.json to build atcore in flatpak

Diff Detail

Repository
R256 Flatpak packaging for KDE Applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello requested review of this revision.Mar 1 2018, 11:43 PM
rizzitello created this revision.
rizzitello retitled this revision from - Attempt to build atcore flatpak to Attempt to build atcore flatpak.Mar 1 2018, 11:45 PM
rizzitello edited the summary of this revision. (Show Details)
rizzitello added a reviewer: Flatpak.
rizzitello added a subscriber: Flatpak.
apol added inline comments.Mar 2 2018, 12:00 AM
org.kde.atcore.json
5 ↗(On Diff #28369)

5.10 is available and we are transitioning to it. Unless you have a strong preference, I suggest staying in 5.10.

15 ↗(On Diff #28369)

This seems wrong: "-DCMAKE_INSTALL_PREFIX=$(qtpaths --install-prefix)" why do you do it?

rizzitello added a comment.Mar 2 2018, 12:18 AM

We do not set a prefix in our cmake . Would you suggest using -DCMAKE_INSTALL_PREFIX=/usr instead?

rizzitello marked 2 inline comments as done.Mar 2 2018, 12:31 AM
rizzitello updated this revision to Diff 28370.Mar 2 2018, 12:31 AM
  • updated to 5.10
  • prefix to /usr
apol added inline comments.Mar 2 2018, 2:57 AM
org.kde.atcore.json
15 ↗(On Diff #28370)

No, remove CMAKE_INSTALL_PREFIX, applications need to go to /app.

You will see if you try to run this it won't work. It's very easy to test, you just need flatpak-builder installed.
https://community.kde.org/Guidelines_and_HOWTOs/Flatpak

rizzitello updated this revision to Diff 28399.Mar 2 2018, 12:33 PM
  • update to build qtcharts
rizzitello added a comment.Mar 2 2018, 12:38 PM

I have removed the prefixes and attempted to make the flatpak. Qtcharts is needed to build our test gui I added that but it does not install . Could you provide some guidence on how to get qtcharts made in flatpak?

apol added a comment.Mar 3 2018, 2:11 AM

Maybe we will have to include it in the Sdk. It's a limitation of Qt.

Would you submit this in the todo/ subdirectory and I'll look into it?
Also should this include atelier or is atcore a full application on its own? (I thought it was just the framework)

rizzitello added a comment.EditedMar 3 2018, 2:17 AM

Yes I will move this todo. This is atcore the framework. We also ship a
test GUI with it for now, when atelier is ready we will turn off the GUI in
this package.

rizzitello updated this revision to Diff 28447.Mar 3 2018, 3:27 AM
  • Move to todo
apol accepted this revision.Mar 5 2018, 12:39 AM
This revision is now accepted and ready to land.Mar 5 2018, 12:39 AM
Closed by commit R256:2820ca2b2eb9: Attempt to build atcore flatpak (authored by rizzitello). · Explain WhyMar 5 2018, 1:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMtodo/org.kde.atcore.json (29 lines)

Diff 28653

View Options

todo/org.kde.atcore.json

Loading...