Differential D10949

Clean up CustomDevicesActivity
ClosedPublic
Actions

Authored by nicolasfella on Mar 1 2018, 4:32 PM.

Details

Reviewers
mtijink
Group Reviewers
KDE Connect
Commits
R225:679b163bd5bc: Clean up CustomDevicesActivity
Summary

Won't have a practical impact, but Lint is happy

Test Plan

Add entries to ip list

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Mar 1 2018, 4:32 PM
nicolasfella created this revision.
nicolasfella retitled this revision from Clean up CustonDevicesActivity to Clean up CustomDevicesActivity.Mar 1 2018, 4:37 PM
mtijink requested changes to this revision.Mar 3 2018, 2:31 PM
mtijink added a subscriber: mtijink.
mtijink added inline comments.
src/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java
157–158

The whole list can be joined using String.join()

This revision now requires changes to proceed.Mar 3 2018, 2:31 PM
nicolasfella updated this revision to Diff 28497.Mar 3 2018, 3:58 PM

Use String.join()

nicolasfella updated this revision to Diff 28498.Mar 3 2018, 4:16 PM

Do it right

nicolasfella added a comment.Mar 3 2018, 4:17 PM

String.join() requires Java 8. I bumped the requirement, but I'm not sure if there could be side effects

mtijink added a comment.Mar 3 2018, 4:33 PM
In D10949#217581, @nicolasfella wrote:

String.join() requires Java 8. I bumped the requirement, but I'm not sure if there could be side effects

I don't think that's a good idea (see https://developer.android.com/studio/write/java8-support.html). But apparently there's also TextUtils.join (see https://stackoverflow.com/questions/33802971/alternative-for-string-join-in-android).

nicolasfella updated this revision to Diff 28506.Mar 3 2018, 5:42 PM

Use TextUtils.join()

nicolasfella updated this revision to Diff 28508.Mar 3 2018, 6:19 PM

Remove unneeded if

nicolasfella marked an inline comment as done.Mar 3 2018, 6:20 PM
mtijink accepted this revision.Mar 4 2018, 10:32 AM
This revision is now accepted and ready to land.Mar 4 2018, 10:32 AM
Closed by commit R225:679b163bd5bc: Clean up CustomDevicesActivity (authored by nicolasfella). · Explain WhyMar 4 2018, 12:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28587

View Options

src/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java

Loading...