Differential D10870

[PackageUrlInterceptor] Don't rewrite "inline"
ClosedPublic
Actions

Authored by broulik on Feb 26 2018, 2:40 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R242:4dda85971f1b: [PackageUrlInterceptor] Don't rewrite "inline"
Summary

When omitting the third "location" argument of Qt.createQmlObject it will instead use "inline" [1] as path and will run through the entire URL interceptor even logic.

[1] https://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/qml/qml/v8/qqmlbuiltinfunctions.cpp#n1134

Test Plan

Task Manager no longer enters the complicated "I dont know what this is" guessing code path of the url interceptor

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 26 2018, 2:40 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 26 2018, 2:40 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
broulik requested review of this revision.Feb 26 2018, 2:40 PM
hein accepted this revision.Feb 26 2018, 11:25 PM
This revision is now accepted and ready to land.Feb 26 2018, 11:25 PM
Closed by commit R242:4dda85971f1b: [PackageUrlInterceptor] Don't rewrite "inline" (authored by broulik). · Explain WhyFeb 28 2018, 11:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28258

View Options

src/plasmaquick/packageurlinterceptor.cpp

Loading...