Differential D1085

[KSysGuardProcessList] Don't forward keys with modifiers (except shift) to the search field
ClosedPublic
Actions

Authored by broulik on Mar 8 2016, 2:05 PM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R111:4b14421cf723: [KSysGuardProcessList] Don't forward keys with modifiers (except shift) to…
Summary

This breaks shortcuts like Ctrl+A to select all. The same approach is used for invoking KRunner on the desktop.
Shift-only modifier is allowed so uppercase letters can also be input properly.

BUG: 335177
FIXED-IN: 5.6.0

Test Plan

Ctrl+A when the table view has focus works
If I start typing without Shift works, with Shift works, with AltGr works, with AltGr shift works

Diff Detail

Repository
R111 KSysguard Library
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 2613.Mar 8 2016, 2:05 PM
broulik retitled this revision from to [KSysGuardProcessList] Don't forward keys with modifiers (except shift) to the search field.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R111 KSysguard Library.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptMar 8 2016, 2:05 PM
broulik updated this object.Apr 6 2016, 7:30 AM
graesslin accepted this revision.Apr 6 2016, 7:30 AM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Apr 6 2016, 7:30 AM
Closed by commit R111:4b14421cf723: [KSysGuardProcessList] Don't forward keys with modifiers (except shift) to… (authored by broulik). · Explain WhyApr 6 2016, 8:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mprocessui/ksysguardprocesslist.cpp (4 lines)

Diff 2613

View Options

processui/ksysguardprocesslist.cpp

Loading...