Plasma browser MPRIS canPlay shouldn't depend on the actual playing status
ClosedPublic

Authored by mtijink on Feb 24 2018, 5:32 PM.

Details

Summary

At KDE Connect we had some visual glitches whenever the plasma browser integration reported playing or paused. The cause was that the player was already signalled as paused, but canPlay was not signalled as true yet.

This diff fixes the issue by just always reporting true. This is also what the specifications require (see https://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html#Property:CanPlay)

Test Plan

The glitch never appeared for me, but the code compiles and works fine with this change.

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mtijink created this revision.Feb 24 2018, 5:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 24 2018, 5:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mtijink requested review of this revision.Feb 24 2018, 5:32 PM

I can confirm that this fixes the glitch

broulik accepted this revision.Feb 25 2018, 5:40 PM

Makes sense. Thanks!

This revision is now accepted and ready to land.Feb 25 2018, 5:40 PM
This revision was automatically updated to reflect the committed changes.