Yay, cleaning up is an important part in keeping the code healthy.

Still I wonder what this code did in the past. Applying this patch to the stable branch (which does not have 543f0b9cc958), I cannot find any breakage, while you say I should. GammaRay and mInformationLabel->setObjectName("mInformationLabel") tell me that this would affect the label that displays the filename in the fullscreen top bar.

I tend to land this, but will first wait for your comment so we don't cause any accidental breakage.

Not related to this patch, but when testing I found an interesting bug: Open Gwenview, externally change colour scheme (Gwenview adapts), press F11 twice: Gwenview forgets the new colour scheme (a restart will fix this, of course). I wouldn't worry too much about it for now, though.

@rkflx Hmm you're right, I mixed things up here. The removed code affects mInformationLabel, not mThumbnailBar which is where we apply the stylesheet.

I took screenshots to compare, and this actually does have an effect, it darkens the information label ever so slightly.

I suppose the question is whether that slight change is necessary, or we can simply bin this revision.

EDIT: I've updated this to replace it with the background role

In D10781#214682, @rkflx wrote:

• Any other places currently using dark()or light()?
• Should KUrlNavigator and crop toolbar have the same (darker) colour?
• In fullscreen Browse mode, KUrlNavigator has a slightly different background than the buttons on its left and right. Bring it in line, or emphasize?

D10880: Improve background color code for URL Navigator and adjacent fullscreen toolbars should sort out all these!