Added XML file to highlight OpenSCAD .scad files.
Details
Diff Detail
- Repository
- R216 Syntax Highlighting
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Thanks for the contribution. Before we integrate this, would you agree to change the license to MIT? This license is preferred for new highlighting files.
Also, could you please also provide a test file we can add to Autotest/input for unit testing? This file should preferably also use the MIT license.
Would be nice if you provide another iteration before we commit this.
In case anyone wants a more complex test file, I'm attaching one (written by me, MIT license):
@julianstirling Can you profile the full xml file again? This patch does not contain the .xml file anymore, so in the current form I cannot commit this as is.
I am confused. If I look in the commit history of this revision there are two diffs, the first commit, and then the subsequent commit. Can phabricator not handle both of them sequentially?
Oh, I was following the guide here https://community.kde.org/Infrastructure/Github_Mirror
So everything I uploaded was a git format-patch, which makes a patch file for each commit I made. I shall look into arc when I get a chance.
Yeah, all commits need to be in a single patch here.Try doing git format-patch HEAD^^, which will include the last two commits.
Hi,
This has been sitting idle for about 6 weeks. @dhaumann is everything OK with the current patch for integration
Cheers
Julian