Highlighting for OpenSCAD

Authored by julianstirling on Feb 21 2018, 3:58 PM.



Added XML file to highlight OpenSCAD .scad files.

Diff Detail

R216 Syntax Highlighting
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
julianstirling created this revision.Feb 21 2018, 3:58 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 21 2018, 3:58 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
julianstirling requested review of this revision.Feb 21 2018, 3:58 PM
ngraham added a subscriber: ngraham.
dhaumann requested changes to this revision.Feb 21 2018, 9:40 PM
dhaumann added a subscriber: dhaumann.

Thanks for the contribution. Before we integrate this, would you agree to change the license to MIT? This license is preferred for new highlighting files.

Also, could you please also provide a test file we can add to Autotest/input for unit testing? This file should preferably also use the MIT license.

Would be nice if you provide another iteration before we commit this.

This revision now requires changes to proceed.Feb 21 2018, 9:40 PM

Added the test file as requested and updated the license to MIT.

In case anyone wants a more complex test file, I'm attaching one (written by me, MIT license):

Oops, looks like your last update replaced the original change.

@julianstirling Can you profile the full xml file again? This patch does not contain the .xml file anymore, so in the current form I cannot commit this as is.

julianstirling planned changes to this revision.Feb 25 2018, 1:18 AM

I am confused. If I look in the commit history of this revision there are two diffs, the first commit, and then the subsequent commit. Can phabricator not handle both of them sequentially?

Hm, did you update with arc diff, or did you do this differently?

Oh, I was following the guide here https://community.kde.org/Infrastructure/Github_Mirror
So everything I uploaded was a git format-patch, which makes a patch file for each commit I made. I shall look into arc when I get a chance.

Yeah, all commits need to be in a single patch here.Try doing git format-patch HEAD^^, which will include the last two commits.

git format-patch HEAD^^ creates two separate patch files...

git diff HEAD^^ HEAD > ../PatchCombined.patch has hopefully done the trick.

This has been sitting idle for about 6 weeks. @dhaumann is everything OK with the current patch for integration

dhaumann accepted this revision.May 27 2018, 5:05 PM

Looks good, will integrate!

This revision is now accepted and ready to land.May 27 2018, 5:05 PM
Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. · View Herald TranscriptMay 27 2018, 5:05 PM
This revision was automatically updated to reflect the committed changes.