Differential D1069

Fix length returned from PanelView::geometryByDistance
ClosedPublic
Actions

Authored by drosca on Mar 4 2016, 11:18 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:3c9d4a1db209: Fix length returned from PanelView::geometryByDistance
R871:3c9d4a1db209: Fix length returned from PanelView::geometryByDistance
Summary

PanelView::length() is not actual length.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 2559.Mar 4 2016, 11:18 AM
drosca retitled this revision from to Fix length returned from PanelView::geometryByDistance.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptMar 4 2016, 11:18 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
drosca added a comment.Mar 4 2016, 11:23 AM

I'm not sure if this should go to Plasma/5.6 as it exposes a bug in ContainmentInterface::adjustToAvailableScreenRegion. Fun fact, it was working mostly alright with the wrong available region :D

The bug is that it now basically operates on available rect (and not region), so if there is floating panel (not maximized) it will treat it as it if was maximized.
I don't think I can fix it for KF 5.20, don't want to rush it.

mart added a subscriber: mart.Mar 4 2016, 11:33 AM

hmm, how this can expose that bug in particular? seems quite unrelated

drosca added a comment.Mar 4 2016, 11:37 AM

availableScreenRegion is constructed from screen region minus panel rects (and panel rect = geometryByDistance(0))

drosca added a comment.Mar 4 2016, 12:11 PM

Scrath that, it's the Dialog positioning that uses rect instead of region (and that's unrelated to this). ContainmentInterface::adjustToAvailableScreenRegion is fine.

davidedmundson accepted this revision.Mar 18 2016, 6:33 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Mar 18 2016, 6:33 PM
Closed by commit R120:3c9d4a1db209: Fix length returned from PanelView::geometryByDistance (authored by drosca). · Explain WhyMar 19 2016, 11:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/panelview.cpp (2 lines)

Diff 2847

View Options

shell/panelview.cpp

Loading...