Differential D10684

[Drop Job] Create proper trash file on linking
ClosedPublic
Actions

Authored by broulik on Feb 20 2018, 3:27 PM.

Details

Reviewers
hein
Group Reviewers
Frameworks
Plasma
Commits
R241:c600f0cb823e: [Drop Job] Create proper trash file on linking
Summary

Plasma wants to remove the default trash icon on the desktop.
This change ensures dropping Trash from e.g. Dolphin will result in a fully functional (i.e. reflecting trash state and proper "Trash" label) trash icon being dropped.

Test Plan

Dropped "Trash" place from Dolphin to desktop, got a "Trash" icon with proper icon.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 20 2018, 3:27 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 20 2018, 3:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 20 2018, 3:27 PM
broulik mentioned this in D10588: No icons on the desktop by default.
hein accepted this revision.Feb 20 2018, 3:28 PM
This revision is now accepted and ready to land.Feb 20 2018, 3:28 PM
Closed by commit R241:c600f0cb823e: [Drop Job] Create proper trash file on linking (authored by broulik). · Explain WhyFeb 28 2018, 12:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/copyjob.cpp (4 lines)

Diff 28261

View Options

src/core/copyjob.cpp

Loading...