When a profile property is changed via the command line or an ESC sequence
a new temp profile is created and applied, this resets the zoom values in
the views connected to the session.
Save zoom font sizes and restore them after the new profile is applied.
BUG: 386643
FIXED-IN: 18.04
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Thanks for the patch! Please follow the formatting guidelines here: https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch
Specifically, remove "BUG: 386643" from the title, and put it on its own line in the Summary section.
Also, please populate the Test Plan field with the results of your testing. Thanks!
That's what I get for using arc...
No need in this particular case; since I don't have commit access to KDE's git, Kurt commits the patch if it's accepted and he phrases the commit messages himself, with all the necessary keywords including BUG: .
It's a good habit anyway, since if you or he pushed using arc, then that keyword would trigger the commit hook and close the bug automatically.
If you're having trouble with arc, I recommend reading https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
[...]
If you're having trouble with arc, I recommend reading https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
Thanks. I'll certainly have a look there.
I notice w/ this patch, if you change the font size via shortcut and then edit profile, you get a new profile w/o a name.
| src/SessionManager.cpp | ||
|---|---|---|
| 271 | ignore this - won't work w/o more work | |
| src/SessionManager.cpp | ||
|---|---|---|
| 271 | I tried using 'const TerminalDisplay *' after reading your previous comment, and I reached the same conclusion, that it won't work. Even if getVTFont() and setVTFont() become const member functions, QWidget::setFont() isn't a const member function... | |
IIUC if a profile property is changed via the cmd or an ESC sequence, konsole switches to a new unnamed profile (which is a clone of the current profile).