Details
- Reviewers
dhaumann - Commits
- R216:933eecb13d9a: Support case-insensitive WordDetect
Diff Detail
- Repository
- R216 Syntax Highlighting
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
In general looks good, and it even revealed a bug as I understand.
However, the KTextEditor framework still has its own implementation of the syntax highlighting. Can you also provide a patch there, so both implementations behave the same?
| src/lib/rule_p.h | ||
|---|---|---|
| 249 ↗ | (On Diff #27496) | Could you initialize this to CaseInsensitive with in-class member initialization? |
It seems that KTextEditor does not have the problem because KateHlWordDetect is based on KateHlStringDetect which uses the inSensitive parameter.
| src/lib/rule_p.h | ||
|---|---|---|
| 249 ↗ | (On Diff #27496) | Yes, but it is in any case overwritten by doLoad(). StringDetect and others do not have this initialization either, should I also make the modification? |
Ok, good catch. Given the uninitialized variables in the other classes, this is good. Will integrate.