Support case-insensitive WordDetect

Authored by jpoelen on Feb 18 2018, 9:20 PM.

Diff Detail

R216 Syntax Highlighting
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
jpoelen created this revision.Feb 18 2018, 9:20 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 18 2018, 9:20 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
jpoelen requested review of this revision.Feb 18 2018, 9:20 PM
dhaumann accepted this revision.Feb 19 2018, 7:40 AM

In general looks good, and it even revealed a bug as I understand.

However, the KTextEditor framework still has its own implementation of the syntax highlighting. Can you also provide a patch there, so both implementations behave the same?


Could you initialize this to CaseInsensitive with in-class member initialization?

This revision is now accepted and ready to land.Feb 19 2018, 7:40 AM

It seems that KTextEditor does not have the problem because KateHlWordDetect is based on KateHlStringDetect which uses the inSensitive parameter.


Yes, but it is in any case overwritten by doLoad(). StringDetect and others do not have this initialization either, should I also make the modification?
In fact, I do not think it's relevant because the analysis tools would no longer detect "uninitialized" variables in the case, for example, of calling doMatch before doLoad.

Ok, good catch. Given the uninitialized variables in the other classes, this is good. Will integrate.

This revision was automatically updated to reflect the committed changes.