pipe loading of album data through proxy model so that qml does not have to know about the album model, similar to all other proxy models
Details
Details
- Reviewers
mgallien - Group Reviewers
Elisa - Commits
- R255:617c81ca348a: pipe loading of album data through proxy model
album data is loaded correctly from all albums view and single artist view
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Just a small change and this should be good. Sorry for the delay.
| src/models/singlealbumproxymodel.cpp | ||
|---|---|---|
| 101 | You should use a qobject_cast. This makes the cast works or fails but only when the sourceModel is not an AlbumModel object. You should also handle this failure case. Just in case we reuse this code in another context. | |