Differential D10630

Optional barcodes in libprison
ClosedPublic
Actions

Authored by svuorela on Feb 18 2018, 10:33 AM.

Details

Reviewers
vkrause
mlaurent
Commits
R459:7b1b2b76b9e0: Allow barcodes to be nullpointers
Summary

createBarcode in libprison might sometimes return nullpointers. The cases where this is true is expanding with https://phabricator.kde.org/D10603, so prepare the code to handle it.

Patch written against 17.08

Test Plan

So far, only build tested.

Diff Detail

Repository
R459 Akonadi Contacts
Lint
Lint Skipped
Unit
Unit Tests Skipped
svuorela created this revision.Feb 18 2018, 10:33 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 18 2018, 10:33 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
svuorela requested review of this revision.Feb 18 2018, 10:33 AM
mlaurent added a comment.Feb 18 2018, 1:18 PM

Ok seems logical.
Please commit in master not 17.08 :)
Regards

mlaurent accepted this revision.Feb 18 2018, 1:18 PM
This revision is now accepted and ready to land.Feb 18 2018, 1:18 PM
svuorela added a comment.Feb 18 2018, 4:12 PM

@mlaurent : I would love to add it to stable and not to master, since next frameworks release might trigger these issues, and that's coming out before 18:04

mlaurent added a comment.Feb 18 2018, 6:11 PM

ok but stable is not 17.08 for sure

Closed by commit R459:7b1b2b76b9e0: Allow barcodes to be nullpointers (authored by svuorela). · Explain WhyFeb 18 2018, 8:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27457

View Options

src/akonadi-contacts/contactviewer.cpp

Loading...