Differential D10613

Make it possible for actions to show submenus
ClosedPublic
Actions

Authored by apol on Feb 17 2018, 6:45 PM.

Details

Reviewers
mart
Group Reviewers
Kirigami
Commits
R169:dd2886259168: Make it possible for actions to show submenus
Summary

When using the ToolBarApplicationHeader we don't show the submenu, which
makes us miss some features from the ContextDrawer.
Still it doesn't seem to be possible to have submenus in QQC2.Menu, something
for the future I guess

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Feb 17 2018, 6:45 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 17 2018, 6:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Feb 17 2018, 6:45 PM
apol updated this revision to Diff 27454.Feb 18 2018, 9:44 AM

Usability

mart added a subscriber: mart.Feb 19 2018, 2:53 PM
mart added inline comments.
src/controls/private/ActionsMenu.qml
36

does it work? icon.* in controls is supposed to work only in qt 5.10 (and qqc2 2.3) which we can't use in kirigami yet as we are on the 2 qt releases ago rule

apol updated this revision to Diff 27547.Feb 19 2018, 3:00 PM

Drop Qt 5.10 dependency

mart accepted this revision.Feb 20 2018, 2:24 PM
This revision is now accepted and ready to land.Feb 20 2018, 2:24 PM
Closed by commit R169:dd2886259168: Make it possible for actions to show submenus (authored by apol). · Explain WhyFeb 20 2018, 2:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27608

View Options

src/controls/private/ActionsMenu.qml

Loading...
View Options

src/controls/private/PrivateActionToolButton.qml

Loading...
View Options

tests/actionsMenu.qml

Loading...