| mwolff | |
| kfunk |
Now there are 2 language profiles: one for C++, another one for C. The language type is determined by mime type.
Since *.h files used in C and C++, by default they are parsed in C++ mode, to change that behavior there is a "Parse *.h headers in plain C" check-box.
BUG: 357774
BUG: 357615
BUG: 57156
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Generally: Please rename "CPP" -> "Cpp" in variable names, etc.
| languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp | ||
|---|---|---|
| 136 | lt -> type or languageType | |
| 154 | Code duplication, factor out functionality? | |
| languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp | ||
| 85 | Initialize in ctor? | |
| languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.h | ||
| 73 | CPP -> Cpp | |
| languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp | ||
| 292 | I've seen this code snippet before :) Please share code | |
Excellent step towards the right direction - many thanks Sergey! I got some more nitpicks, once those and Kevin's are attended to I think we can merge this. Yay! Finally proper C support in KDevelop :)
| languages/clang/tests/test_assistants.cpp | ||
|---|---|---|
| 548 ↗ | (On Diff #2512) | unrelated change, should not be required |
| languages/clang/tests/test_duchain.cpp | ||
| 1575 | This should stay at .c. Actually, we should probably now run the test twice - once for .c and once for .cpp. | |
| languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp | ||
| 136 | and use auto on the lhs. | |
| languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp | ||
| 61 | this breaks backwards compatibility for those that already use the kdevelop 5 beta. could we stick to the old name for Cpp, and only introduce a new key for the two other args? | |
| languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.h | ||
| 40 | indent | |
| 43 | indent | |
| languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp | ||
| 293 | wrap literals with QLatin1String, use .compare with Qt::CaseInsensitive | |
| 305 | auto args = m_settings->defaultParserArguments(); | |
| languages/plugins/custom-definesandincludes/kcm_widget/parserwidget.cpp | ||
| 94 | using sender() is not so nice, please make this two distinct functions and connect them individually | |
| languages/plugins/custom-definesandincludes/kcm_widget/parserwidget.ui | ||
| 20 | wrap the *.h in <code> or <tt> tags | |
With this patch I get
"warning: argument unused during compilation: '-nostdinc++' [-Wunused-command-line-argument]"
when parsing C files. Although innocuous, it would be nice not to have this warning being spammed.
I don't think it's related to this patch. You'll probably get the same warning even without it, e.g. if you change language profile to C. Adding -Wno-unused-command-line-argument to the parser arguments can be a solution here.
| languages/plugins/custom-definesandincludes/kcm_widget/parserwidget.ui | ||
|---|---|---|
| 176 | Well, I actually think that it's quite useful. E.g. I've seen a couple of project that started as plain C, but with time were ported to C++, without changing file extensions. So IMO it's ok to keep it here. Though I agree that it's not a common use case, and those items at least should be moved at the bottom of the list or masked otherwise... | |