Refactor saveMode handling to use enums instead of ints
ClosedPublic

Authored by rkflx on Feb 12 2018, 5:37 PM.

Details

Summary

Things like case 0 make it really hard to work with the code and
having access to the current state of the Save button is needed
for a subsequent patch.

Test Plan

Spectacle still remembers the last used save state, defaults work too.

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx requested review of this revision.Feb 12 2018, 5:37 PM
rkflx created this revision.

+1. Will test and offer code review later tonight.

ngraham accepted this revision.Feb 13 2018, 3:32 AM

No regressions and much cleaner code. +1!

This revision is now accepted and ready to land.Feb 13 2018, 3:32 AM
This revision was automatically updated to reflect the committed changes.