[DrKonqi] Reliably quit when closing report assistant
ClosedPublic

Authored by broulik on Feb 29 2016, 11:00 PM.

Details

Summary

The finished signal is not emitted when the dialog is just closed and neither is the reject signal.
Since the dialog is DeleteOnClose we can just connect to QObject::destroyed

Test Plan

I think there's a better solution but I finally found why I often ended up with a bunch of drkonqis still hanging around when I couldnt be bothered to actually finish filing a bug :)

Also, creative use of a lambda in the original code.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 2503.Feb 29 2016, 11:00 PM
broulik retitled this revision from to [DrKonqi] Reliably quit when closing report assistant.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptFeb 29 2016, 11:00 PM
broulik edited the test plan for this revision. (Show Details)Feb 29 2016, 11:00 PM
graesslin accepted this revision.Mar 21 2016, 10:59 AM
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.Mar 21 2016, 10:59 AM
This revision was automatically updated to reflect the committed changes.