lazy initialize as much as possible
ClosedPublic

Authored by mgallien on Feb 9 2018, 6:28 AM.

Details

Summary

lazy initialize the standard actions

lazy initialize all the models and the MusicListenersManager after start

Test Plan

everything seems to work like it used to work
the interface is shown earlier but with a busy indicator

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Feb 9 2018, 6:28 AM
mgallien created this revision.
mgallien added a project: Elisa.

Can't say that I noticed much of an improvement, but also found no errors.

mgallien updated this revision to Diff 27581.Feb 19 2018, 10:46 PM
  • lazy initialize MediaPlayList
  • finish modifications for everything
  • small remaining change
  • last fixes
  • another small number of fixes

should be final now

mgallien retitled this revision from [WIP] lazy initialize as much as possible to lazy initialize as much as possible.Feb 19 2018, 10:46 PM
astippich requested changes to this revision.Feb 21 2018, 6:25 PM

Some comments inline

src/elisaapplication.cpp
265

If new ... is used here, shouldn't delete... also be called upon quit?

src/qml/ElisaMainWindow.qml
202

Gives warning here due to missing "elisa."

206

same as above

This revision now requires changes to proceed.Feb 21 2018, 6:25 PM
mgallien updated this revision to Diff 27736.Feb 21 2018, 9:24 PM
mgallien marked 2 inline comments as done.
  • lazy initialize MediaPlayList
  • finish modifications for everything
  • small remaining change
  • last fixes
  • another small number of fixes
  • access to the media play list through the elisa variable
  • use std::unique_ptr to avoid memory leaks
mgallien marked an inline comment as done.Feb 21 2018, 9:26 PM

Thanks for the review. I have fixed all three issues.

astippich accepted this revision.Feb 22 2018, 6:57 AM
This revision is now accepted and ready to land.Feb 22 2018, 6:57 AM
This revision was automatically updated to reflect the committed changes.