Differential D10370

Fix parsing of sound and image urls with relative paths
ClosedPublic
Actions

Authored by hriesenbeck on Feb 7 2018, 7:52 PM.

Details

Reviewers
whiting
tcanabrava
Group Reviewers
KDE Edu
Commits
R339:ce08ff30dfa5: Fix parsing of sound and image urls with relative paths
Summary

Relative file paths for sound and image files were not correctly parsed
into QUrl objects. The reason for this is, that the previous used
QUrl::isRelative() does not work as its name lets suppose. So the
relative file path detection is changed to QDir methods.

Unit tests for sound and image file path parsing were added.

BUG: 389517

Test Plan

Run unit tests

Diff Detail

Repository
R339 KEduVocDocument Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hriesenbeck created this revision.Feb 7 2018, 7:52 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFeb 7 2018, 7:52 PM
hriesenbeck requested review of this revision.Feb 7 2018, 7:52 PM
tcanabrava accepted this revision.Nov 2 2018, 4:20 PM
This revision is now accepted and ready to land.Nov 2 2018, 4:20 PM
Restricted Application added a subscriber: kde-edu. · View Herald TranscriptNov 2 2018, 4:20 PM
Closed by commit R339:ce08ff30dfa5: Fix parsing of sound and image urls with relative paths (authored by hriesenbeck). · Explain WhyNov 3 2018, 7:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 44802

View Options

.arcconfig

Loading...
View Options

keduvocdocument/autotests/readerkvtml2test.cpp

Loading...
View Options

keduvocdocument/readerwriters/keduvockvtml2reader.cpp

Loading...