Differential D10308

Send hoverLeave or hoverMotion after touch up on decoration
ClosedPublic
Actions

Authored by graesslin on Feb 4 2018, 8:24 PM.

Details

Reviewers
ngraham
romangg
Group Reviewers
KWin
Plasma
Commits
R108:911176a887be: Send hoverLeave or hoverMotion after touch up on decoration
Summary

On touch down a first hover motion is sent to the decoration. Thus e.g. a
button enters the hovered state. On touch release so far the decoration
did not get a leave event resulting in the button still being hovered.

This change ensures the leave event is sent or if the pointer is also on
the decoration a motion to the pointer position is sent.

BUG: 386231
FIXED-IN: 5.12.1

Test Plan

New test case and manual testing to verify that the maximize
button is no longer hovered after touch down/up on it

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Feb 4 2018, 8:24 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 4 2018, 8:24 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
graesslin requested review of this revision.Feb 4 2018, 8:24 PM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 4 2018, 8:24 PM
Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 4 2018, 8:27 PM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 21 2018, 5:08 PM
romangg accepted this revision.Feb 25 2018, 1:18 AM
This revision is now accepted and ready to land.Feb 25 2018, 1:18 AM
Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 25 2018, 1:18 AM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 25 2018, 9:27 AM
graesslin planned changes to this revision.Feb 25 2018, 12:41 PM

I need to rework the patch, it broke with 338c7362c9fbb37f1fb8beb9a50644b585d8135e

Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 25 2018, 12:41 PM
This revision was not accepted when it landed; it landed in state Changes Planned.Feb 25 2018, 1:11 PM
Closed by commit R108:911176a887be: Send hoverLeave or hoverMotion after touch up on decoration (authored by graesslin). · Explain Why
This revision was automatically updated to reflect the committed changes.
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 25 2018, 1:11 PM

Revision Contents
Changeset List

Diff 28022

View Options

autotests/integration/decoration_input_test.cpp

Loading...
View Options

autotests/integration/quick_tiling_test.cpp

Loading...
View Options

input.cpp

Loading...