small refactoring to reduce size of main qml file
Details
Details
- Reviewers
mgallien - Group Reviewers
Elisa - Commits
- R255:d4900e6a9265: move application menu to own file
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for your work.
It is probably better to directly use the context variable without redefining other variables.
| src/qml/ApplicationMenu.qml | ||
|---|---|---|
| 29 | If I understand correctly how qml works, elisa is a context variable that you can access from everywhere. This is not needed | |
Comment Actions
I had missed the following messages:
qrc:/qml/ApplicationMenu.qml:84: ReferenceError: qmlQuitAction is not defined
qrc:/qml/ApplicationMenu.qml:92: ReferenceError: qmlQuitAction is not defined
Please fix them before landing this review.