base listitemdelegate color on selected, not checked
AbandonedPublic

Authored by mart on Jan 31 2018, 11:12 AM.

Details

Reviewers
hein
sebas
Summary

I can't say that I'm grasping the logic here completely, buuuuut...

In systemsettings, the delegates for categories change color after being
clicked a second time. As far as I understand, this happens because
they're checked the first time clicked, then unchecked. The seond time
clicked should leave them selected (and thus in the same color), and the
reverse logic is to base the color on the selected property, not the
checked property.

Am I correct, though?

Test Plan

started system settings, selected a category, selected the same category, color stays the same

Diff Detail

Repository
R169 Kirigami
Branch
sebas/syselistitemdelegate
Lint
No Linters Available
Unit
No Unit Test Coverage
sebas created this revision.Jan 31 2018, 11:12 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptJan 31 2018, 11:12 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas requested review of this revision.Jan 31 2018, 11:12 AM
mart added inline comments.Jan 31 2018, 11:46 AM
src/controls/private/DefaultListItemBackground.qml
25

the bug is actually in that Qt.tint() call which was trying to generate the inactive selection color, but is wrong.

the background color should still change like it did, like everything else (like the dolphin sidebar does for instance) if we want to disable it, we should disable it globally, and is a checkbox in the colors kcm

mart commandeered this revision.Feb 15 2018, 11:27 AM
mart abandoned this revision.
mart edited reviewers, added: sebas; removed: mart.

solved in a different way