use ModelTest from Qt to better test all models
ClosedPublic
Actions

Authored by mgallien on Jan 26 2018, 9:17 PM.

Details

Reviewers

astippich

Group Reviewers

Elisa

Commits

Summary

use ModelTest from Qt to better test all models

fix one very small bug in MediaPlayList

add the correct license for modeltest that is a copy from Qt base module

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Jan 26 2018, 9:17 PM

mgallien created this revision.

The modeltest.cpp file is missing.

This revision now requires changes to proceed.Jan 27 2018, 9:45 AM

sorry for the missing files

This revision is now accepted and ready to land.Jan 27 2018, 10:35 AM

This revision was automatically updated to reflect the committed changes.

		Path
A	M	LICENSE.GPL3-EXCEPT (704 lines)
M		autotests/CMakeLists.txt (5 lines)
M		autotests/albummodeltest.cpp (5 lines)
M		autotests/allalbumsmodeltest.cpp (5 lines)
M		autotests/allartistsmodeltest.cpp (3 lines)
M		autotests/alltracksmodeltest.cpp (8 lines)
M		autotests/mediaplaylisttest.cpp (50 lines)
A	M	autotests/modeltest.h (82 lines)
A	M	autotests/modeltest.cpp (581 lines)
M		src/mediaplaylist.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26018	30afde6		Jan 26 2018, 9:17 PM	★	★
Diff 2	26029	30afde6	- add missing files	Jan 27 2018, 9:51 AM	★	★
Diff 3	26077	80936dd	R255:5208333a7d4e44404bb102bf9b9484fa9dc62cc4	Jan 27 2018, 5:14 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
0e73a551eca6	f7a49c8a7c79	24b9cc3ee4f8	Matthieu Gallien	add missing files	Jan 27 2018, 9:49 AM
24b9cc3ee4f8	3f04d351b9af	076a5465ddf6	Matthieu Gallien	use ModelTest from Qt to better test all models (Show More…)	Jan 26 2018, 9:15 PM
076a5465ddf6	db67c673914d	276d0742421c	Matthieu Gallien	fix one very small bug in MediaPlayList	Jan 26 2018, 9:09 PM
276d0742421c	50c00d02da2d	30afde603c35	Matthieu Gallien	use ModelTest from Qt to better test all models	Jan 26 2018, 8:44 PM