[Examples] Fix build
ClosedPublic

Authored by broulik on Jan 25 2018, 7:47 AM.

Details

Reviewers
rjvbb
Group Reviewers
Plasma
Commits
R242:595fd8805430: [Examples] Fix build
Summary
  • Add QStringLiteral et al where appropriate
  • Also add override keyword to avoid warnings
  • Minor style changes and cleanups
Test Plan

Built plasma-framework with -DBUILD_EXAMPLES=ON, it compiled
Ran exampleplasmashell, got a window with an analog clock in it

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 25 2018, 7:47 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 25 2018, 7:47 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
broulik requested review of this revision.Jan 25 2018, 7:47 AM
broulik edited the summary of this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, rjvbb.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 25 2018, 7:48 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Jan 25 2018, 7:49 AM
rjvbb accepted this revision.Jan 25 2018, 9:54 AM

LGTM.

The examples seem to have a circular runtime dependency on (at least) plasma-desktop. Is that just an opportunistic dependency (= they'd work fine you'd only just installed plasma-framework)?

This revision is now accepted and ready to land.Jan 25 2018, 9:54 AM
This revision was automatically updated to reflect the committed changes.