[New Mail Notifier] Set default action to open email

Authored by broulik on Jan 24 2018, 9:14 AM.


Group Reviewers

Since Plasma 5.10 it supports the "default" action on a notification which is invoked when clicking the notification popup itself.
It's also used by Gnome [1] and Unity, which don't have dedicated action buttons to begin with.

The option to show a visible "Open" button (shortened from "Show mail") is still avilable but I didn't even knew it existed and clicking the notification popup itself is a natural thing to do.

[1] https://developer.gnome.org/notification-spec/

Test Plan

Got a new email, clicked the popup, email opened.
Activated "show open button" in settings, got an email, clicked "Open" button, email opened

Diff Detail

R44 KDE PIM Runtime
Lint Skipped
Unit Tests Skipped
broulik created this revision.Jan 24 2018, 9:14 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJan 24 2018, 9:14 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
broulik requested review of this revision.Jan 24 2018, 9:14 AM

Nope I don't want to open kmail if I click on notification.
I added a button to signal it for avoiding to open kmail by mistake.
With your patch you activate it all the time, it's not as I want

Why would you accidentally do it all the time? When you try to dismiss the notification?

Yep when I try to hide it or by mistake I click on it.
I added an option "Show button" to avoid it.

Otherwise this button is not useful, but as I explain it's useful :)

broulik abandoned this revision.Jan 24 2018, 2:01 PM

FWIW, I would support this. I get notifications from Thunderbird and there's no easy way to go to the app and view the email from the notification.

davidre added a subscriber: davidre.Wed, Aug 7, 7:56 AM

Can we revisit this? If you are notified about multiple mails there is no way to get from the notification to KMail currently since no buttons are shown.

Probably the best way would be with a new patch. :)