Differential D10049

[PATCH 3/4] Add initial support for built-in javascript functs
ClosedPublic
Actions

Authored by aheinecke on Jan 23 2018, 1:52 PM.

Details

Reviewers
aacid
Group Reviewers
Okular
Maniphest Tasks
T7805: Okular: Add support for JavaScript AFSimple_Calculate and textfield content calculation
Commits
R223:cead2bbef3c2: Add initial support for built-in javascript functs
Summary

This starts by adding support for AFSimple_Calculate which
is the standard "calculate" function in Adobe Acrobat Pro.

Diff Detail

Repository
R223 Okular
Lint
Lint Skipped
Unit
Unit Tests Skipped
aheinecke updated this revision to Diff 25877.Jan 24 2018, 12:25 PM

Updated to use Event Object

aacid added a subscriber: aacid.Feb 3 2018, 7:59 PM
aacid added inline comments.
core/script/builtin.js
36

why set ret to 1 if ret is 0? is this because you want to initialize? then you should test i is 0 otherwise 3*0*4 will be 4?

aheinecke updated this revision to Diff 26762.Feb 8 2018, 1:51 PM

Fix first grade math error. *blushes*

aheinecke marked an inline comment as done.Feb 8 2018, 1:53 PM
aheinecke added inline comments.
core/script/builtin.js
36

Indeed and nice catch :-). For PRD I wanted to set the start value to 1 and not 0. I made this more explicit now.

aacid accepted this revision.Feb 21 2018, 11:18 PM
This revision is now accepted and ready to land.Feb 21 2018, 11:18 PM
Closed by commit R223:cead2bbef3c2: Add initial support for built-in javascript functs (authored by aheinecke, committed by aacid). · Explain WhyFeb 21 2018, 11:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (4 lines)
AMcore/script/builtin.js (61 lines)
AMcore/script/builtin.qrc (5 lines)
Mcore/scripter.cpp (18 lines)

Diff 25817

View Options

CMakeLists.txt

Loading...
View Options

core/script/builtin.js

Loading...
View Options

core/script/builtin.qrc

Loading...
View Options

core/scripter.cpp

Loading...