Differential D10034

[Purpose Menu] Create QQmlApplicationEngine on demand
ClosedPublic
Actions

Authored by broulik on Jan 23 2018, 9:20 AM.

Details

Reviewers
apol
Commits
R495:d6452fc298f8: [Purpose Menu] Create QQmlApplicationEngine on demand
Summary

Loading the QML file accounts for 2% of Spectacle's startup time. Do it the first time it's actually done.

Test Plan

Was still able to share files through Purpose in Spectacle

Diff Detail

Repository
R495 Purpose Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 23 2018, 9:20 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 23 2018, 9:20 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
broulik requested review of this revision.Jan 23 2018, 9:20 AM
apol accepted this revision.Jan 23 2018, 12:21 PM
This revision is now accepted and ready to land.Jan 23 2018, 12:21 PM
Closed by commit R495:d6452fc298f8: [Purpose Menu] Create QQmlApplicationEngine on demand (authored by broulik). · Explain WhyJan 23 2018, 1:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/menu.cpp (19 lines)

Diff 25813

View Options

src/widgets/menu.cpp

Loading...