this patch adds the possibility to have the corrresponding reconciliation date displayed alongside each account on the home page. This is optional and can be enabled or disabled via a setting in the config dialog.
Details
- Reviewers
tbaumgart wojnilowicz - Group Reviewers
KMyMoney - Commits
- R261:68ac2fe9a737: display reconciliation date on homepage
Diff Detail
- Repository
- R261 KMyMoney
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
For some reason, master crashes when starting. This is not related to your patch and maybe caused by my local environment, but I cannot take a look at the changes from a visual point of view. I wonder if the new column is a bit wide. Please take a look at my other comments.
kmymoney/views/khomeview_p.h | ||
---|---|---|
261 | Use const auto lastReconciliationDate = ... here |
I like this. I have been thinking about filing a wish list for it for some time.
I do agree with Thomas that the column seems too wide, but in English, it is because of "Reconciliation." Personally, I would make the column title "Last Reconcile" or "Last Reconciled" which would be narrower, even if it isn't completely grammatically correct.
I also think the "Current Balance" column is wider than necessary, but I assume that is unrelated to this patch, and might be looked at in the future.
This looks better to me. Hopefully Thomas can also check it after solving his crash issue.
Would anyone with write access to the repo mind taking care of the merge, please?
Thanks!