Revert "GIT_SILENT: minor qstring optimization"
dfe28172ccec
Actions

Authored by mglb on Dec 9 2019, 9:15 PM.

Description

Revert "GIT_SILENT: minor qstring optimization"

This reverts commit f96deb39aacc2e9f22a9b3bda0a2b003f0d85104.

This was anti-optimization.
QStringLiteral is a QString created at build time. Initialization of
QString with it has no overhead.
QLatin1String is 8 bit C string wrapper which needs run-time conversion
to 16 bit encoding used in QString.

Details

Committed

mglb	Dec 9 2019, 9:41 PM

Parents

R319:cd3cfda01974: Don't use 0/nullptr as flag

Branches

Unknown

Tags

Unknown

References

refs/merge-requests/57/head, refs/keep-around/dfe28172ccece920b32e49899b29ee114d5380bc

Reverts

R319:f96deb39aacc: GIT_SILENT: minor qstring optimization

mglb committed R319:dfe28172ccec: Revert "GIT_SILENT: minor qstring optimization" (authored by mglb).Dec 9 2019, 9:41 PM

mglb added a reverted change: R319:f96deb39aacc: GIT_SILENT: minor qstring optimization.Jun 15 2020, 3:52 AM

Changes (17)

				Path	Packages
	M			src/Application.cpp
	M			src/ColorSchemeEditor.cpp
	M			src/ColorSchemeManager.cpp
	M			src/EditProfileDialog.cpp
	M			src/KeyboardTranslatorManager.cpp
	M			src/ProcessInfo.cpp
	M			src/ProfileManager.cpp
	M			src/Session.cpp
	M			src/SessionController.cpp
	M			src/ViewContainer.cpp
	M			src/ViewManager.cpp
	M			src/autotests/PartTest.cpp
	M			src/autotests/ShellCommandTest.cpp
	M			src/autotests/TerminalInterfaceTest.cpp
	M			src/main.cpp
	M			tools/uni2characterwidth/template.cpp
	M			tools/uni2characterwidth/uni2characterwidth.cpp