marcoscarpetta (Marco Scarpetta)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 4 2017, 7:39 AM (379 w, 1 d)
Availability
Available

Recent Activity

May 27 2018

marcoscarpetta updated the diff for D12993: Allow saving screenshots in custom auto-generated subdirectories.
May 27 2018, 9:43 PM · Spectacle
marcoscarpetta added inline comments to D12993: Allow saving screenshots in custom auto-generated subdirectories.
May 27 2018, 2:52 PM · Spectacle
marcoscarpetta updated the diff for D12993: Allow saving screenshots in custom auto-generated subdirectories.
May 27 2018, 2:48 PM · Spectacle

May 24 2018

marcoscarpetta added inline comments to D12993: Allow saving screenshots in custom auto-generated subdirectories.
May 24 2018, 4:52 PM · Spectacle
marcoscarpetta updated the diff for D12993: Allow saving screenshots in custom auto-generated subdirectories.

Updated according to comments.

May 24 2018, 4:44 PM · Spectacle

May 23 2018

marcoscarpetta added a comment to D12993: Allow saving screenshots in custom auto-generated subdirectories.

Thanks, title and summary are looking much better now.

Tested the patch now. Works really well in general but I could break it by putting a / at the very start or end of the template, resulting in

QImageWriter cannot write image

Regarding the configuration dialog, I wonder whether it would make more sense to use the Location lineedit for choosing the subdirectories, as for Save As the directory part will be ignored anyway, resulting in the Filename field being incorrect. For example:

  • Put the general template help text on top.
  • Location lineedit and subdirectory help text below that.
  • Filename lineedit at the bottom.

I also think that it would make more sense, but I tried it and there are some problems since the Location entry is not a lineedit but a KUrlRequester (% is replaced with %2525). Maybe I could add another lineedit or edit the Filename label to make it more descriptive.

May 23 2018, 8:24 AM · Spectacle

May 21 2018

marcoscarpetta updated the test plan for D12993: Allow saving screenshots in custom auto-generated subdirectories.
May 21 2018, 11:45 AM · Spectacle

May 20 2018

marcoscarpetta updated the diff for D12993: Allow saving screenshots in custom auto-generated subdirectories.
May 20 2018, 1:28 PM · Spectacle
marcoscarpetta requested review of D12993: Allow saving screenshots in custom auto-generated subdirectories.
May 20 2018, 11:24 AM · Spectacle

Feb 6 2017

marcoscarpetta reopened T5272: Warning on 'visibility' attribute of "QDebug& operator<<(QDebug &dbg, const KAsync::Error &error)" as "Open".
Feb 6 2017, 8:10 AM · Sink, KASync
marcoscarpetta added a comment to T5272: Warning on 'visibility' attribute of "QDebug& operator<<(QDebug &dbg, const KAsync::Error &error)".

Ok, I thought that clang had a different syntax for attributes. I found the same error in Sink, this is a patch for it.

Feb 6 2017, 8:10 AM · Sink, KASync

Feb 4 2017

marcoscarpetta closed T5272: Warning on 'visibility' attribute of "QDebug& operator<<(QDebug &dbg, const KAsync::Error &error)" as Invalid.
Feb 4 2017, 8:46 AM · Sink, KASync
marcoscarpetta added a comment to T5272: Warning on 'visibility' attribute of "QDebug& operator<<(QDebug &dbg, const KAsync::Error &error)".

Sorry, I found this just now. You are using clang. Using options from that json file it builds fine.

Feb 4 2017, 8:38 AM · Sink, KASync
marcoscarpetta created T5272: Warning on 'visibility' attribute of "QDebug& operator<<(QDebug &dbg, const KAsync::Error &error)".
Feb 4 2017, 8:12 AM · Sink, KASync