In D14738#316508, @sirgienko wrote:

Hi, @kqwyf, as I see, your GitHub account name is kqwyf, right?
As I see, Github don't connect your commit with your github account, so author this patch on Github is 1160300905.
Should we try to fix this injustice :) and connect your github account with commit author via github support?

Thank you for your help! @pino @asemke @filipesaraiva @sirgienko

• update the type value of MarkdownEntry

• restore the access modifiers of TextEntry

• disable rich text for MarkdownEntry
• make MarkdownEntry inherit from WorksheetEntry

In D14738#312759, @sirgienko wrote:

Do you talk about acceptRichText function?

There may not be an elegant solution (without refactoring) to make the rich text action list support the markdown entry... One solution is to disable the action list for markdown entry. Is that okay?

• make MarkdownEntry editable
• remove latex support from MarkdownEntry

In D14738#310856, @sirgienko wrote:

Okey, I got it. Well, LatexEntry don't protect rendered content from editing (and it Cantor's architectural miscalculation), so maybe MarkdownEntry also don't need it? In this revision, I mean.
The solution of this problem (more integrated and consistent with another code) could be added later and applied for markdown and latex entries (so, I think, @kqwyf, you don't need solve this problem)

The two solutions are in the code. You can uncomment one of them to apply it.

• feature(incomplete): user can edit a markdown entry by double clicking

In D14738#310269, @sirgienko wrote:

In D14738#310261, @kqwyf wrote:

Here comes a problem...

The reason I'd like to make rendered markdown entries uneditable is that, if the user edited a rendered markdown entry, then we could never convert the content (in html) back to markdown.
To imitate the behaviors of latex entries better, I thought it's a good idea that the cursor can move on the markdown entries while they can't be edited.

In this moment, if you haven't libspectre (or latex), you can't exec latex entry (well, you can, but nothing happens) and another actions allowed. If you haven't libspectre and load worksheet with
latex formulas, we can see rendrered images (okay, in this moment, we can't see, but I working on this problem and this will be fix soon on master), but I could edit unrendered latex entries and convert renderered to unrendered entries by double click.

Here comes a problem...

In D14738#309981, @filipesaraiva wrote:

Could @kqwyf implement this using the same behaviour of LaTeX entry?

In D14738#309642, @sirgienko wrote:

In D14738#309636, @kqwyf wrote:

In this patch, a markdown entry without Discount support behaves just like a text entry, except that the latex formulas can be re-edited. I think it's a useful feature.

Nitpick: Maybe, then user without Discount edit rendered markdown entry from loaded worksheet, we should drop rendered result? So, users don't forget reevaluate this edited entry later.

• update the implementation of the last fix

• fix: focus appears at wrong position in markdown entries

In D14738#309632, @kqwyf wrote:

• change all the indentation tabs into spaces
• remove extra changes
• update CMakeLists.txt
• bump the ui version in cantor_part.rc
• fix the memory leak when converting markdown to HTML
• feature: save evaluation results for markdown entries

• change all the indentation tabs into spaces
• remove extra changes
• update CMakeLists.txt
• bump the ui version in cantor_part.rc
• fix the memory leak when converting markdown to HTML
• feature: save evaluation results for markdown entries

In D14738#309034, @pino wrote:

Nitpick: please provide a consistent indentation in the new files -- they seem to mix spaces and tabs.
Also, was this tested when cantor is built without the Discount library? How does it behave when trying to add/edit markdown entries, and trying to load worksheets with such entries?

In D14738#309012, @sirgienko wrote:

@kqwyf, after previous two diff changes, Markdown entries starts don't work for me (don't evaluate), is they works on your machine?

I think problem, that
#cmakedefine discount_FOUND 1 don't work now, because we start use Discount_FOUND.

• update macros about Discount

In D14738#308938, @sirgienko wrote:

@kqwyf Could you find Discount twice? Because I could found Discount only in first cmake run, and in seconds I have

-- The following OPTIONAL packages have not been found:

 * Discount

• fix the bug that it won't find Discount when doing cmake twice.
• add package properties for Discount

In D14738#308508, @filipesaraiva wrote:

Thank you for your contribution @kqwyf. I built with Discount and it is working fine. I built without Discount, I could run Cantor correctly and the options to insert Markdown entries continues to show, but it is a problem with others entries options like LaTeX. Maybe it is time to some refactoring in this part.

For a first contribution it is very good, congrats. Stay with us to develop more features and fix bugs. :)

I will wait some hours for comments of the others reviewers, if they are nothing to ask I will push to you.

• remove the commented code
• fix a bug that a command entry is appended when clicking a new markdown entry

• add FindDiscount.cmake

• use Discount to convert Markdown to HTML

In D14738#307487, @asemke wrote:

@kqwyf thanks for this contribution. We just had a discussion recently about adding the support for markdown to Cantor, see also some https://phabricator.kde.org/T9108. cpp-markdown requries boost for regex. We should avoid introducing here another dependency for something that can also be done with Qt. Are you familiar with libraries mentioned in T9108 or with Discovery mentioned by @pino ?

In D14738#307471, @pino wrote:

Please no embedded copies of 3rdparty libraries.
Also, okular already uses the Discount library for its markdown backend, so what about using it instead?

In D14738#307584, @filipesaraiva wrote:

Hello @kqwyf, are you from that course in a Chinese university about open source contribution?