gsmolarczyk (Gustaw Smolarczyk)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 12 2015, 4:50 PM (441 w, 6 d)
Availability
Available

Recent Activity

Feb 14 2016

gsmolarczyk added a comment to D583: Fix DUChainUtils::getInheriters..

I have tested these changes (btw: I had to compile 5.0 branch instead of master, it's a bit confusing that the newest fixes are firstly introduced on a release branch and then merged into master from time to time).

Feb 14 2016, 8:37 PM · KDevelop

Feb 2 2016

gsmolarczyk added a comment to D583: Fix DUChainUtils::getInheriters..

Well, I did not check the other proposed solution of stopping importing the semantic parent. That could fix this issue, but in my opinion would be more of a hack, unless the importing stuff should really be a synonym for inheritance.

Feb 2 2016, 10:27 PM · KDevelop

Nov 24 2015

gsmolarczyk abandoned D590: Fix DUChainUtils::getInheriters..

Pushed by accident, ignore. The real diff is D583.

Nov 24 2015, 8:49 PM
gsmolarczyk added a comment to D583: Fix DUChainUtils::getInheriters..
In D583#11138, @mwolff wrote:

Just a question: Is the clang builder correct in importing the base for the case you have in your unit test?

class foo { class inner {}; };

Why is inner importing foo - does anyone know? If that wouldn't be the case, then this patch here wouldn't be required. So before we accept this patch, I'd appreciate if someone could dig in a bit deeper and clarify whether it isn't a bug in kdev-clang that triggers the issue, instead of a generic DUChain issue here.

Nov 24 2015, 8:37 PM · KDevelop
gsmolarczyk updated the diff for D583: Fix DUChainUtils::getInheriters..

Perform the requested changes.

Nov 24 2015, 8:29 PM · KDevelop
gsmolarczyk retitled D590: Fix DUChainUtils::getInheriters. from to Fix DUChainUtils::getInheriters..
Nov 24 2015, 8:22 PM
gsmolarczyk added a comment to D584: Add unit test for DUChainUtils::getInheriters..
In D584#11132, @mwolff wrote:

nice, lgtm! Do you have commit rights?

Nov 24 2015, 2:16 PM · KDevelop

Nov 23 2015

gsmolarczyk added a reviewer for D584: Add unit test for DUChainUtils::getInheriters.: KDevelop.
Nov 23 2015, 6:19 PM · KDevelop
gsmolarczyk added a reviewer for D583: Fix DUChainUtils::getInheriters.: KDevelop.
Nov 23 2015, 6:19 PM · KDevelop
gsmolarczyk added a project to D584: Add unit test for DUChainUtils::getInheriters.: KDevelop.
Nov 23 2015, 6:18 PM · KDevelop
gsmolarczyk retitled D584: Add unit test for DUChainUtils::getInheriters. from to Add unit test for DUChainUtils::getInheriters..
Nov 23 2015, 6:17 PM · KDevelop
gsmolarczyk added a project to D583: Fix DUChainUtils::getInheriters.: KDevelop.
Nov 23 2015, 6:16 PM · KDevelop
gsmolarczyk retitled D583: Fix DUChainUtils::getInheriters. from to Fix DUChainUtils::getInheriters..
Nov 23 2015, 6:15 PM · KDevelop